E2151. Allow reviewers to bid on what to review #2150
Conversation
This reverts commit 89a4bde.
Generated by expertiza-bot |
This reverts commit 89a4bde. Modify names of files for review bid views Delete all views and partials explicitly for review_bids Create new shared partial used for table line of both reviews and topics in sign up Remove unnecessary portion of base_table_name Modify view files for review bids to render properly Delete unnecessary view components for review bidding Fix incorrect render of partial in review_bid_table_line view Update url for algorithm and test cases
…ids"" This reverts commit 81eafe4.
… further investigation
Signed-off-by: WeiRui Wang <wnwang@ncsu.edu>
|
Hello, general note that some of the commits in this pull request and subsequent repo have weird dates because one of our developers was adjusting their system clock for the purposes of testing. We apologize if that causes any issues. Also, please note that for this feature, an external webservice must also be established, as referenced in the document related to this topic. |
…sary instance variable and supplying proper algorithm url
… current stage of the assignment.
+ Reviewed phase finding related logic DRYness. + Concluded related internal logic is no longer necessary.
|
Serious issues with the GUI on firefox render this feature nearly unusable. I was able to barely select to place my bids. Needs additional work before, can probably be merged. |
Description of the changes includes a series of optimization for the code of which are DRY principle violation. Further refactoring will also allow the code be more suitable for merging.
Before the pull request, changes has been made and consist of an overhaul across the code base related to E2085.
Further details and changes can be viewed at Files Changed and E2151 Wiki.
Note: During a review of our pull request and commits history, we have noticed an issue where the date of the commits is different than the actual date of the commit because of our system’s time and date setup during the testing. Had the issue ever caused the confusion of time of commits, do check the time of files change instead of the commits timestamp.